yuqian90 commented on a change in pull request #7276: [AIRFLOW-5391] Do not run 
skipped tasks when they are cleared
URL: https://github.com/apache/airflow/pull/7276#discussion_r379344105
 
 

 ##########
 File path: tests/operators/test_python.py
 ##########
 @@ -396,7 +397,7 @@ def test_without_dag_run(self):
                 elif ti.task_id == 'branch_2':
                     self.assertEqual(ti.state, State.SKIPPED)
                 else:
-                    raise Exception
+                    raise ValueError(f'Invalid task id {ti.task_id} found!')
 
 Review comment:
   I was changing this from `Exception` to `ValueError` in one of the new test 
cases I added following previous suggestions from reviewers. So I replaced the 
same usage in this test module too. I will revert this change if you prefer 
leaving the existing code untouched.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to