potiuk commented on issue #7191: [AIRFLOW-4030] second attempt to add singularity to airflow URL: https://github.com/apache/airflow/pull/7191#issuecomment-586633655 > Questions: > > * where does example_singularity_operator.py go - it used to be under contrib/example_dags but now, that entire folder is empty? in the meantime we completed AIP-21 and every integration is now moved to 'providers' package.Singularity will need to be moved to providers/singularity > * this error is triggering for the docs (is it related to the above)? I don't see any script_files with grep, nor do I see how super() relates to the example_singularity_operator.py file. just look where any of the other providers are added - there is a TOC where you can navigate to your documentation - otherwise users won't be able to find the docs. > > ``` > writing additional pages... search/usr/local/lib/python3.6/site-packages/sphinx_rtd_theme/search.html:20: RemovedInSphinx30Warning: To modify script_files in the theme is deprecated. Please insert a <script> tag directly in your theme instead. this one is misleading it's just a Sphinx internal warning. real warning is much higher in the log (the document is not in any toctree or similar. I think I had a PR that filtered out the false warnings.. I will try to dig I out as I I indeed misleading. > These docs tests were passing before (but nothing has changed) so what has changed that I don't know about? That's AIP-21 in the making. For Airflow 2.0 we do a lot of consistency changes. AIP-21 is Al about consistency y between operators, It was planned over last half a year and we just completed I (few more final touches). I was actually leading it band vast majority of the moves happened in last month by members of my team in fact, It's been announced at the devliscie several times, but I guess you aren't following it (and it's no wonder) > For the mock tests, the author that helped me put "awesome-image" and "awesome-command" in the mock tests - I'm not familiar enough with setting up mocks to understand how this mock is supposed to work (it's not supposed to use real singularity?) Mocks just pretend to talk to the external integrations and they are all about what unit testing is all about. all unit tests should use mocking. As of recently we also added pytest.mark.integration mark to mark integration tests that should work with real local integrations (such as singularity) we are also in process of adding system tests that are going to talk to real external systems -GCP for example. All this is explained in detail in TESTING.rst
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
