sarah-johnson opened a new pull request #7428: [AIRFLOW-4526] Poll k8s logs to 
avoid problem with kubernetes logs --follow
URL: https://github.com/apache/airflow/pull/7428
 
 
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Our team has been affected by this issue. After reading through the issue 
history and reviewing the various proposals it seems like this was caused by an 
underlying problem with the kubernetes logs --follow behavior, as was detailed 
by @dorranh on the issue discussion. This change which was [already implemented 
in a fork](https://github.com/discordapp/incubator-airflow/pull/8) by 
@samschlegel works around the problem by polling logs instead of using k8s 
following.
   
   I am a first time contributor but would like to help with seeing through 
this issue being solved in an official Airflow release. I am not sure about the 
test writing aspect - there aren't any tests currently in the 
test_kubernetes_pod_operator for get_logs. Would be glad to follow through with 
writing tests, and/or changing any implementation details, based on your 
feedback or suggestions. Thank you for your consideration.
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = 
JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with 
`[AIRFLOW-XXXX]`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to