ashb commented on a change in pull request #7430: [AIRFLOW-6816] Separated out
common utils
URL: https://github.com/apache/airflow/pull/7430#discussion_r379894057
##########
File path: scripts/ci/ci_before_install.sh
##########
@@ -15,25 +15,14 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-
-set -xeuo pipefail
+set -x
MY_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-# shellcheck source=scripts/ci/_utils.sh
-. "${MY_DIR}/_utils.sh"
-
-basic_sanity_checks
-
-script_start
+# shellcheck source=scripts/ci/_script_init.sh
+. "${MY_DIR}/_script_init.sh"
Review comment:
What do you think of changing the pattern for how we import this new file to:
```suggestion
. "$( dirname "${BASH_SOURCE[0]}" )/_script_init.sh"
```
and then also setting `MY_DIR` in it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
