ashb commented on a change in pull request #7245: [AIRFLOW-6624] Improve
webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#discussion_r380105893
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -263,40 +264,31 @@ def monitor_gunicorn(gunicorn_master_proc):
sys.exit(gunicorn_master_proc.returncode)
if args.daemon:
- base, ext = os.path.splitext(pid)
- ctx = daemon.DaemonContext(
- pidfile=TimeoutPIDLockFile(base + "-monitor" + ext, -1),
- files_preserve=[handle],
- stdout=stdout,
- stderr=stderr,
- signal_map={
- signal.SIGINT: kill_proc,
- signal.SIGTERM: kill_proc
- },
Review comment:
Given these exist as properties of DaemonContext I would say we leave them
~there~here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
