ashb commented on a change in pull request #7439: [AIRFLOW-6204][depends on
6763] Create GoogleSystemTest class
URL: https://github.com/apache/airflow/pull/7439#discussion_r380144171
##########
File path: tests/conftest.py
##########
@@ -159,6 +174,15 @@ def pytest_configure(config):
config.addinivalue_line(
"markers", "runtime(name): mark test to run with named runtime"
)
+ config.addinivalue_line(
+ "markers", "system(name): mark test to run with named system"
+ )
+ config.addinivalue_line(
+ "markers", "long_lasting(name): mark test that run for a long time
(many minutes)"
+ )
+ config.addinivalue_line(
+ "markers", "credential_file(name): mark tests that require credential
file in CREDENTIALS_DIR"
Review comment:
Does it make sense for credential_file to be a "marker" in the pytest-sense,
This isn't something I'd imagine we'd select by on the command line (but system
etc do make sense as markers).
Are these perhaps instead just a property that should be set on the
SystemTest sub-class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
