potiuk commented on issue #7458: [AIRFLOW-6838][WIP] Introduce real subcommands 
for Breeze
URL: https://github.com/apache/airflow/pull/7458#issuecomment-587978552
 
 
   While I like the spirit of that change,. Breeze grew a lot in terms of 
functionality and maybe we should think of refactoring the structure of 
commands soon.
   
   But I think it's not the right way of doing it.
   
   First of all you are just about to have a lot of conflicts as we are 
splitting breeze into functions. Secondly it does not take into account 
getopt's behaviour so it is for sure wrong (We define all the available options 
in breeze-complete and getopt by default assumes -- or - params. So not only 
autocomplete will not work but also parsing options won't work either.
   
   I think we need to do much bolder change if we want to introduce 
sub-commands - we should rewrite it in another language (python or golang). But 
complicating parsing of parameters is not a good idea. 
   
   Unless you use ready to use library - for example here 
http://people.tuebingen.mpg.de/maan/gsu/ then we could write it in  bash (but 
it's not a good idea as it is GPL2 and it does not support ZSH I believe). I 
think we should talk about it and think if that's the right time to think of 
such change or maybe better to leave it for after we deliver the current 
important 2.0 features - prod image, API and others. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to