[
https://issues.apache.org/jira/browse/AIRFLOW-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039653#comment-17039653
]
ASF GitHub Bot commented on AIRFLOW-6839:
-----------------------------------------
potiuk commented on pull request #7460: [AIRFLOW-6839] even more mypy speed
improvements
URL: https://github.com/apache/airflow/pull/7460
Require_serial:true is better choice than pass_filename: false as it can
speed-up mypy for single file changes.
Significant gains can be achieved for single file changes and no cache for
all
other files. This is majority of cases for our users who have pre-commits
installed as hooks because most people change only few files and never run
check with --all-files
When just one file is changed and no cache is built, the difference is
drastic:
require_serial: true = 4s
pass_filenames: false = 13s
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Even more mypy speedup
> ----------------------
>
> Key: AIRFLOW-6839
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6839
> Project: Apache Airflow
> Issue Type: Improvement
> Components: pre-commit
> Affects Versions: 2.0.0, 1.10.9
> Reporter: Jarek Potiuk
> Priority: Major
>
> require_serial:true is better choice than pass_filename: false as it can
> speed-up mypy for single file changes.
> Significant gains can be achieved for single file changes and no cache for
> all other files. This is majority of cases for our users who have pre-commits
> installed as hooks because most people change only few files and never run
> check with --all-files
> When just one file is changed and no cache is built, the difference is
> drastic:
> require_serial: true (4s)
>
> {code:java}
> Run
> mypy.................................................................PassedRun
> mypy.................................................................Passed
> real 0m4,080s user 0m0,283s sys 0m0,095s
> {code}
> pass_filenames: false: (13s)
> {code:java}
> time pre-commit run mypy time pre-commit run mypyRun
> mypy.................................................................Passed
> real 0m13,756suser 0m0,281ssys 0m0,099s{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
