feluelle commented on a change in pull request #7410: [AIRFLOW-6790] Add basic
Tableau Integration
URL: https://github.com/apache/airflow/pull/7410#discussion_r381179743
##########
File path: setup.py
##########
@@ -321,6 +321,7 @@ def write_version(filename: str =
os.path.join(*["airflow", "git_version"])):
]
salesforce = [
'simple-salesforce>=0.72',
+ 'tableauserverclient'
Review comment:
I think we could (and maybe should) since the current version v0.9 seems to
be near a v1 release which could be a release with breaking changes (I don't
know). I couldn't find anything related to release schedule / plan nor
versioning of releases.
Actually because you are bringing this up I am wondering if we should create
general rules for pinning versions of dependencies. **This of course should be
discussed in the dev list.**
It is a very complicated topic.
I think there are several points that could be relevant:
* knowing the releases and versioning of the dependency
* having one or more users in the community which have responsibilities in
the project the dependency belongs to. (like committer status for apache
projects, etc.)
* ...
If we have an issue due to a new release:
Maybe we should somewhere write down our dependencies and keep track of the
issues we have towards non-pinning a dependency. So that we can better
understand their releases. Every dependency has their own semantic versioning
of releases.
Maybe we should add a list of requirements when we want to add a non-pinned
dependency?!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
