ashb commented on a change in pull request #7276: [AIRFLOW-5391] Do not run 
skipped tasks when they are cleared
URL: https://github.com/apache/airflow/pull/7276#discussion_r381942853
 
 

 ##########
 File path: airflow/models/skipmixin.py
 ##########
 @@ -65,13 +68,53 @@ def skip(self, dag_run, execution_date, tasks, 
session=None):
                 ti.end_date = now
                 session.merge(ti)
 
-            session.commit()
+    @provide_session
+    def skip(
+        self, dag_run, execution_date, tasks, session=None,
+    ):
+        """
+        Sets tasks instances to skipped from the same dag run.
+        If `task_id` is a valid attribute, store the list of skipped task IDs 
to XCom
 
 Review comment:
   ```suggestion
   
           If this instance has a `task_id` attribute, store the list of 
skipped task IDs to XCom
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to