[
https://issues.apache.org/jira/browse/AIRFLOW-6854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041106#comment-17041106
]
ASF GitHub Bot commented on AIRFLOW-6854:
-----------------------------------------
MikaYuoadas commented on pull request #7474: [AIRFLOW-6854] Fix missing
typing_extensions on python 3.8
URL: https://github.com/apache/airflow/pull/7474
All import from `typing_extensions` should be done through
`airflow.typing_compat` to avoid breakage under python >= 3.8
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Missing import `typing_extensions` when running under py38
> ----------------------------------------------------------
>
> Key: AIRFLOW-6854
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6854
> Project: Apache Airflow
> Issue Type: Bug
> Components: build
> Affects Versions: 1.10.9
> Reporter: Akim Sadaoui
> Assignee: Akim Sadaoui
> Priority: Major
>
> Version 1.10.9 (and latest master) crashes when running with python 3.8:
> {code:java}
> File
> "/home/asadaoui/.virtualenvs/airflow/lib/python3.8/site-packages/airflow/serialization/json_schema.py",
> line 26, in <module>
> from typing_extensions import Protocol
> ModuleNotFoundError: No module named 'typing_extensions'{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
