[
https://issues.apache.org/jira/browse/AIRFLOW-6855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041254#comment-17041254
]
ASF GitHub Bot commented on AIRFLOW-6855:
-----------------------------------------
mtagle commented on pull request #7475: AIRFLOW-6855: Escape
project_dataset_table in SQL query in gcs to bq …
URL: https://github.com/apache/airflow/pull/7475
…operator
Without escaping, if the project is specified in project_dataset_table and
contains a -,
the query will fail with an error.
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GCS to BQ load will fail with syntax error if specified project has a - in it
> -----------------------------------------------------------------------------
>
> Key: AIRFLOW-6855
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6855
> Project: Apache Airflow
> Issue Type: Bug
> Components: gcp
> Affects Versions: 1.10.9
> Reporter: Moira Tagle
> Assignee: Moira Tagle
> Priority: Minor
>
> If you try to run a GCS -> BQ load that explicitly specifies a destination
> project that contains a -, the sql that runs to emit the final log message:
> SELECT MAX(\{id}) FROM \{project_dataset_table}
> will fail because the - in the project is not escaped in the SQL.
> datasets and tables cannot have - in them, and if you are implicitly getting
> the project from the configured connection it will not explicitly be in the
> SQL, so this is only a problem if the project is explicitly specified and it
> has a - in it.
> To fix this, the project_dataset_table should be escaped in the SQL query.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
