potiuk commented on issue #7456: [AIRFLOW-6817] - Move airflow __init__.py 
imports to sub-packages
URL: https://github.com/apache/airflow/pull/7456#issuecomment-589965503
 
 
   One thing to consider.
   
   I would like to see if we can think slightly differently here.
   
   This is a change that is super easy to add to automated "migration 
assistant" tool that we will have to do anyway. I think we will have far more 
issues to deal with in terms of backwards compatibility (for example 
bash_operator and python_operator have moved).
   
   I think personally that with the 2.0 migration we should simply make people 
aware that they have to migrate using migration tool (or manually). Otherwise 
they will have a false sense of having "compatible" dags. I think telling 
people they will be able to move their dags to 2.0 and they will continue to 
work as usual, is a bit miscommunication (or even a bit of a lie - we know it's 
not going to work in a number of cases). 
   
   Migration to 2.0 will be anyway pain for many people but they can deal with 
one pain at at time - i.e. DAG migration first, then migrate to 2.0 Airflow 
infrastructure. 
   
   We can make it  easier for people to migrate to 2.0 - if they will have the 
new "back-ported" providers packages installed - the migration to the "both 
1.10 and 2.0" compatible dags might be done automatically even BEFORE migration 
to 2.0 and our tool should be able to tell how "ready" you are to migrate to 
2.0. For now - I believe none of the changes we've done prevents us from having 
Dags that are both 1.0 and 2.0 compatible (and if we find one - we can still 
easily fix it in master to keep that possibility).
   
   The "migration assistant" can produce both - 1.10 and 2.0 compatible DAGs 
(for example imports changed to "airflow.models.DAG" etc. This should be very 
easy with tools like Bowler : https://pybowler.io/  - we used it successfully 
to refactor tons of python code (basically all providers code!) and we can 
easily produce dag-migration assistant that can be used by people.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to