[
https://issues.apache.org/jira/browse/AIRFLOW-6882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042617#comment-17042617
]
ASF GitHub Bot commented on AIRFLOW-6882:
-----------------------------------------
BasPH commented on pull request #7504: [AIRFLOW-6882] Implement SageMakerHook
list_training_jobs method + convenience method for iterating list_* requests
URL: https://github.com/apache/airflow/pull/7504
The SageMakerHook currently does not support any list_* operations (there
are a few...
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker.html).
This PR adds a generic method for iterating over list_* operation results and
one implementation for list_training_jobs.
By default, boto3 caps the number of results to 10. This is configurable up
to 100. I've implemented `_list_request` as a convenience function for making
multiple requests to AWS in case more results are available.
`SageMakerHook.list_training_jobs()` makes use of this convenience function.
Not sure if tests should be added because all existing SageMakerHook tests
simply test the number of calls to the underlying client's methods, which
doesn't really validate correct behaviour IMO?
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add an AWS SageMakerHook method for listing training jobs
> ---------------------------------------------------------
>
> Key: AIRFLOW-6882
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6882
> Project: Apache Airflow
> Issue Type: Bug
> Components: aws
> Affects Versions: 1.10.10
> Reporter: Bas Harenslak
> Assignee: Bas Harenslak
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
