ashb commented on a change in pull request #7484: [AIRFLOW-6864][depends on 6863] Make airflow/jobs pylint compatible URL: https://github.com/apache/airflow/pull/7484#discussion_r382925729
########## File path: airflow/utils/helpers.py ########## @@ -30,6 +30,8 @@ from airflow.configuration import conf from airflow.exceptions import AirflowException +BACKFILL_PREFIX = "backfill_" Review comment: This feels a bit out of place here in "helpers". This isn't a helper, it's a constant to do with jobs. I think this would be better placed in either base_jobs.py, or `jobs/__init__.py`. That or this variable should become `BACKFILL_JOB_PREFIX.` or `JOB_PREFIX_BACKFILL` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
