kaxil commented on a change in pull request #7525: [AIRFLOW-XXXX] [WIP] Fix (?)
flaky tests in kubernetes tests
URL: https://github.com/apache/airflow/pull/7525#discussion_r383487640
##########
File path: tests/runtime/kubernetes/test_kubernetes_executor.py
##########
@@ -88,6 +88,9 @@ def monitor_task(self, host, execution_date, dag_id,
task_id, expected_final_sta
execution_date=execution_date,
task_id=task_id)
)
+ if result.status_code == 404:
+ check_call(["echo", "api returned 404."])
Review comment:
What is this for?
Quoting from slack too from Matt:
>One thing I thought of, correct me if I’m wrong, is there a possibility for
an infinite loop? Say the status always returns 404, tries also would not
increment. Maybe put the tries increment at the beginning of the loop and
increase the max_tries?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
