Fokko commented on a change in pull request #7489: [AIRFLOW-6869][WIP] Bulk
fetch DAGRuns for _process_task_instances
URL: https://github.com/apache/airflow/pull/7489#discussion_r383706497
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -684,11 +687,36 @@ def _process_dags(self, dagbag, dags, tis_out):
:type dagbag: airflow.models.DagBag
:param dags: the DAGs from the DagBag to process
:type dags: List[airflow.models.DAG]
- :param tis_out: A list to add generated TaskInstance objects
- :type tis_out: list[TaskInstance]
- :rtype: None
+ :rtype: list[TaskInstance]
+ :return: A list of generated TaskInstance objects
"""
check_slas = conf.getboolean('core', 'CHECK_SLAS', fallback=True)
+
+ tis_out = []
+ dag_ids = [dag.dag_id for dag in dags]
Review comment:
```suggestion
dag_ids = {dag.dag_id for dag in dags}
```
This will turn it into a set :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
