mik-laj commented on a change in pull request #7565: [AIRFLOW-6941][WIP] Add
queries count test for create_dagrun
URL: https://github.com/apache/airflow/pull/7565#discussion_r385170832
##########
File path: tests/models/test_dag.py
##########
@@ -1341,3 +1344,26 @@ class DAGsubclass(DAG):
self.assertEqual(hash(dag_eq), hash(dag))
self.assertNotEqual(hash(dag_diff_name), hash(dag))
self.assertNotEqual(hash(dag_subclass), hash(dag))
+
+
+class TestPerformance(unittest.TestCase):
Review comment:
I don't think that's needed. These are very simple and small tests. In the
future, when we introduce integration tests and tests for components, not just
functions, we can do it. For me, this is a unit test, although it has slightly
different assertions. Performance tests are tests that have metrics that can
change in the environment. These tests do not change in the environment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
