zhongjiajie commented on a change in pull request #7572: [AIRFLOW-6948] Remove 
ASCII Airflow from version command
URL: https://github.com/apache/airflow/pull/7572#discussion_r385510607
 
 

 ##########
 File path: airflow/settings.py
 ##########
 @@ -173,8 +173,8 @@ def configure_orm(disable_connection_pool=False):
         # 
https://docs.sqlalchemy.org/en/13/core/pooling.html#disconnect-handling-pessimistic
         pool_pre_ping = conf.getboolean('core', 'SQL_ALCHEMY_POOL_PRE_PING', 
fallback=True)
 
-        log.info("settings.configure_orm(): Using pool settings. pool_size={}, 
max_overflow={}, "
-                 "pool_recycle={}, pid={}".format(pool_size, max_overflow, 
pool_recycle, os.getpid()))
+        log.debug("settings.configure_orm(): Using pool settings. 
pool_size=%d, max_overflow=%d, "
+                  "pool_recycle=%d, pid=%d", pool_size, max_overflow, 
pool_recycle, os.getpid())
 
 Review comment:
   I think it ok, just a small change, unless we create a PR change all log and 
and some static test for it
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to