ashb commented on a change in pull request #6788: WIP: [AIRFLOW-5944] Rendering 
templated_fields without accessing DAG files
URL: https://github.com/apache/airflow/pull/6788#discussion_r385717231
 
 

 ##########
 File path: airflow/serialization/serialized_objects.py
 ##########
 @@ -319,6 +320,9 @@ def serialize_operator(cls, op: BaseOperator) -> dict:
         if op.operator_extra_links:
             serialize_op['_operator_extra_links'] = \
                 cls._serialize_operator_extra_links(op.operator_extra_links)
+        serialize_op['_templated_fields'] = {
+            field: serialize_template_field(getattr(op, field)) for field in 
op.template_fields
 
 Review comment:
   Hmmmmm, not so sure about this -- specifically storing it under 
_templated_fileds, when this value here is different in content to the 
templated_fields on an non-serialized Operator.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to