[
https://issues.apache.org/jira/browse/AIRFLOW-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048385#comment-17048385
]
ASF GitHub Bot commented on AIRFLOW-6870:
-----------------------------------------
msb217 commented on pull request #7596: [AIRFLOW-6870] remove imports from
models module
URL: https://github.com/apache/airflow/pull/7596
Per the issue, I have removed imports from [AIRFLOW-6870] and have added a
module `airflow/models/all_models.py` to be used in the `resetdb` case. The
goal of this is to reduce the number of cyclic dependencies and hopefully
increase performance. This issue stems from [AIRFLOW-6817] and the discussion
below.
https://www.mail-archive.com/[email protected]/msg03496.html
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove models from models.__init__.py
> -------------------------------------
>
> Key: AIRFLOW-6870
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6870
> Project: Apache Airflow
> Issue Type: Improvement
> Components: models
> Affects Versions: 2.0.0
> Reporter: Jarek Potiuk
> Priority: Major
>
> We should remove all models from __init__.py and have a separate
> `all_models.py` which then will be used by resetdb to drop all tables. This
> is a follow-up to AIRFLOW-6817
>
> See the comment
> https://github.com/apache/airflow/pull/7456#discussion_r382758098
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
