mik-laj commented on a change in pull request #7593: [AIRFLOW-6959] Use NULL as
dag.description default value and change r…
URL: https://github.com/apache/airflow/pull/7593#discussion_r386094173
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -99,7 +99,8 @@ <h2>DAGs</h2>
<!-- Column 3: Name -->
<td>
<span>
- <a href="{{ url_for('Airflow.'+ dag.default_view,
dag_id=dag.dag_id) }}" title="{{ dag.description[0:80] + '...' if
dag.description|length > 80 else dag.description }}">
+ <a href="{{ url_for('Airflow.'+ dag.default_view,
dag_id=dag.dag_id) }}"
+ title="{{ dag.description[0:80] + '...' if
dag.description and dag.description|length > 80 else dag.description }}">
Review comment:
Shouldn't we remove the title attribute when dag.description == None?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services