nuclearpinguin commented on a change in pull request #7619: [AIRFLOW-6975] Base
AWSHook AssumeRoleWithSAML
URL: https://github.com/apache/airflow/pull/7619#discussion_r387532026
##########
File path: airflow/providers/amazon/aws/hooks/base_aws.py
##########
@@ -206,6 +212,104 @@ def _get_credentials(self, region_name):
endpoint_url,
)
+ def _assume_role(
+ self,
+ sts_client,
+ extra_config,
+ role_arn,
+ assume_role_kwargs):
Review comment:
Can you please add type annotation? Those really help :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
