sbrandtb commented on issue #6643: [AIRFLOW-6040] Fix KubernetesJobWatcher Read time out error URL: https://github.com/apache/airflow/pull/6643#issuecomment-595132169 @maxirus Sorry, my bad. I did not see in fact that you were setting `timeout_seconds`. However, I still disagree with you setting the `_request_timeout` to `[60, 60]` by default. See my referenced merge request in Kubernetes client about how broken handling that parameter is in the openapi generator project. Either: * You just assume you are smarter than everyone else and that no one needs to set another timeout and just hard code it to some reasonable value (like, 10 seconds - why not?) * *or* you use whatever is set in Airflow's settings * *or* create a new setting for this Because, if the request timeout from settings is something else than `[60, 60]` that means the user conciously put in that value, because the first is the default in Airflow. Please, do not double-default. But in general I agree that setting the `timeout_sconds` is the right approach to fix the actual issue.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
