[ 
https://issues.apache.org/jira/browse/AIRFLOW-6989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052737#comment-17052737
 ] 

ASF GitHub Bot commented on AIRFLOW-6989:
-----------------------------------------

kaxil commented on pull request #7633: [AIRFLOW-6989] Store 
UnRenderedTemplateFields in SerializedDag table
URL: https://github.com/apache/airflow/pull/7633
 
 
   **Note to Reviewer**: Please only check the last commit as the first commit 
is separated to https://github.com/apache/airflow/pull/6788
   Continuation of https://issues.apache.org/jira/browse/AIRFLOW-5944 
(https://github.com/apache/airflow/pull/6788)
   
   Store unrendered Task Instance Template Fields in the DAG serialization 
table. 
   
   
   
   ---
   Issue link: WILL BE INSERTED BY 
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = 
JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with 
`[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Store UnRenderedTemplateFields in SerializedDag table
> -----------------------------------------------------
>
>                 Key: AIRFLOW-6989
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6989
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 2.0.0, 1.10.7
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Major
>              Labels: dag-serialization
>             Fix For: 2.0.0, 1.10.10
>
>
> Continuation of https://issues.apache.org/jira/browse/AIRFLOW-5944
> Store unrendered version in a separate column in the DAG serialization table. 
> This means that each TI would have an associated rendered field without 
> creating an extra table and duplicating dag_id, task_id & execution_date. 
> Once we start storing a different versions of serialized DAGs we can have 
> each DAG row have its unrendered version.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to