nuclearpinguin commented on a change in pull request #7613: WIP: [AIRFLOW-6978]
Add PubSubPullOperator
URL: https://github.com/apache/airflow/pull/7613#discussion_r389243511
##########
File path: airflow/providers/google/cloud/sensors/pubsub.py
##########
@@ -55,8 +61,15 @@ class PubSubPullSensor(BaseSensorOperator):
:param max_messages: The maximum number of messages to retrieve per
PubSub pull request
:type max_messages: int
- :param return_immediately: If True, instruct the PubSub API to return
- immediately if no messages are available for delivery.
+ :param return_immediately:
+ (Deprecated) This is an underlying PubSub API implementation detail.
+ It has no real effect on Sensor behaviour other than some internal
wait time before retrying
+ on empty queue.
+ The Sensor task will (by definition) always wait for a message,
regardless of this argument value.
+
+ If you want a non-blocking task that does not to wait for messages,
please use
+ :class:`airflow.providers.google.cloud.operators.PubSubPullOperator`
+ instead.
Review comment:
Good!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
