ashb commented on a change in pull request #6788: [AIRFLOW-5944] Rendering 
template_fields without accessing DAG files
URL: https://github.com/apache/airflow/pull/6788#discussion_r389581508
 
 

 ##########
 File path: airflow/models/taskinstance.py
 ##########
 @@ -927,6 +929,10 @@ def signal_handler(signum, frame):
                 start_time = time.time()
 
                 self.render_templates(context=context)
+                if STORE_SERIALIZED_DAGS:
 
 Review comment:
   constant vs reading from `conf.getboolean` everytime wouldn't make a 
difference, as the `airflow.config` is loaded once at main-process start up, 
and the parsing sub-process forks so keeps the same loaded config -- i.e. it 
doesn't re-read the config file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to