kaxil commented on a change in pull request #7674: [AIRFLOW-7022] Simplify
DagFileProcessor.process_file method
URL: https://github.com/apache/airflow/pull/7674#discussion_r390274618
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -842,21 +842,12 @@ def test_find_dags_to_run_includes_subdags(self):
print(self.dagbag.dag_folder)
self.assertGreater(len(dag.subdags), 0)
dag_file_processor = DagFileProcessor(dag_ids=[], log=mock.MagicMock())
- dags =
dag_file_processor._find_dags_to_process(self.dagbag.dags.values(),
paused_dag_ids=())
+ dags =
dag_file_processor._find_dags_to_process(self.dagbag.dags.values())
self.assertIn(dag, dags)
for subdag in dag.subdags:
self.assertIn(subdag, dags)
- def test_find_dags_to_run_skip_paused_dags(self):
- dagbag = DagBag(include_examples=False)
-
- dag = dagbag.get_dag('test_subdag_operator')
Review comment:
We refactored a method: https://github.com/apache/airflow/pull/7587 and
added a test to check the response.
and we relied on the 2 existing test, check the comment here:
https://github.com/apache/airflow/pull/7587#issuecomment-592527753
This test was one of them, we don't need to delete this test, do we?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
