kaxil commented on a change in pull request #7661: [AIRFLOW-7016] Sort dag tags
in the UI
URL: https://github.com/apache/airflow/pull/7661#discussion_r390305943
##########
File path: airflow/www/templates/airflow/dags.html
##########
@@ -105,7 +105,7 @@ <h2>DAGs</h2>
</span>
<div style="float: right; max-width: 70%; text-align:
right; line-height: 160%;">
- {% for tag in dag.tags %}
+ {% for tag in dag.tags | sort(attribute='name') %}
Review comment:
> Why ?
So that if someone removes the sorting code, it should fail the test so we
know that it is broken
> How ?
https://github.com/apache/airflow/blob/master/tests/www/test_views.py#L441
file has got test to check if "certain" text exists or not.
--
The other part what I commented was that maybe we sort the list before we
pass it to the UI
I am happy to merge it as it is for now, but we should take care of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
