swiftomkar commented on a change in pull request #7688: [AIRFLOW-6794] Allow
AWS Operator RedshiftToS3Transfer To Run a Custom Query
URL: https://github.com/apache/airflow/pull/7688#discussion_r391036023
##########
File path: airflow/providers/amazon/aws/operators/redshift_to_s3.py
##########
@@ -107,7 +112,12 @@ def execute(self, context):
credentials = s3_hook.get_credentials()
unload_options = '\n\t\t\t'.join(self.unload_options)
s3_key = '{}/{}_'.format(self.s3_key, self.table) if
self.table_as_file_name else self.s3_key
- select_query = "SELECT * FROM
{schema}.{table}".format(schema=self.schema, table=self.table)
+ if all([self.schema, self.table]):
+ select_query = "SELECT * FROM
{schema}.{table}".format(schema=self.schema, table=self.table)
+ elif self.custom_select_query:
+ select_query = self.custom_select_query
+ else:
+ raise AirflowBadRequest(f"Either (schema, table) or
custom_select_query should be set. They are ({self.schema},{self.table}) and
{self.custom_select_query} now.")
Review comment:
Makes sense. I will make the change. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
