ashb commented on a change in pull request #7693: [AIRFLOW-7046] 
Locale-formatted datetimes (UI only)
URL: https://github.com/apache/airflow/pull/7693#discussion_r391754108
 
 

 ##########
 File path: airflow/www/webpack.config.js
 ##########
 @@ -102,10 +102,6 @@ const config = {
     new CleanWebpackPlugin(['static/dist']),
     new MiniCssExtractPlugin({ filename: '[name].[chunkhash].css' }),
 
-    // MomentJS loads all the locale, making it a huge JS file.
-    // This will ignore the locales from momentJS
-    new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/),
 
 Review comment:
   Do you know how much does this increase the bundle size by?
   
   Is it worth (and possible) to make this one part a separate bundle so it can 
be requested and cached separately?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to