zhongjiajie commented on a change in pull request #7709: [AIRFLOW-7053] Fix
success/failed error in graph without dagrun
URL: https://github.com/apache/airflow/pull/7709#discussion_r392016631
##########
File path: tests/www/test_views.py
##########
@@ -999,7 +1065,7 @@ def __init__(self, test, endpoint):
self.test = test
self.endpoint = endpoint
- def setUp(self): # pylint: disable=invalid-name
+ def setup(self):
Review comment:
Both `setUp` and `tearDown` are function of
`ViewWithDateTimeAndNumRunsAndDagRunsFormTester`, which a helper for more
convenience in test, not inherit from `unittest.TestCase`. So I think is better
to use lowercase and remove `pylint: disable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
