dstandish commented on a change in pull request #6376: [AIRFLOW-5705] Add 
secrets backend and support for AWS SSM
URL: https://github.com/apache/airflow/pull/6376#discussion_r392448705
 
 

 ##########
 File path: airflow/config_templates/default_airflow.cfg
 ##########
 @@ -256,6 +256,15 @@ dag_processor_manager_log_location = 
{AIRFLOW_HOME}/logs/dag_processor_manager/d
 # Default to use task handler.
 task_log_reader = task
 
+[secrets_backend]
+# Name of secrets backend to enable (will precede env vars and metastore in 
search path)
+class_name =
 
 Review comment:
   you could say it is the "fully qualified" name :)
   class path sounds like java to me...
   
   there is another example -- ([api]/auth 
backend)[https://airflow.apache.org/docs/stable/configurations-ref.html#api].
   
   we could call this key "secrets_backend", like is done with , and change the 
section name to `[secrets]`?  WDYT?
   so like this:
   ```
   [secrets]
   secrets_backend = 
   ```
   
   which is better?  too many possibilities!
   
   ```
   [secrets_backend]
   secrets_client = 
   client_kwargs = 
   ```
   ```
   [secrets] # or [secrets_backend]
   
   # choose one from these
   secrets_backend = 
   class_name = 
   class_path
   
   # choose one from these:
   secrets_backend_kwargs = 
   backend_kwargs = 
   config_kwargs = 
   client_kwargs = 
   client_json =
   config_json =
   ```
   
   any proposal?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to