eladkal commented on a change in pull request #7718: [AIRFLOW-5421] Add Presto 
to GCS transfer operator
URL: https://github.com/apache/airflow/pull/7718#discussion_r392558809
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/sql_to_gcs.py
 ##########
 @@ -177,7 +183,7 @@ def _write_local_data_files(self, cursor):
             else:
                 row_dict = dict(zip(schema, row))
 
-                # TODO validate that row isn't > 2MB. BQ enforces a hard row 
size of 2MB.
+                # TODO: validate that row isn't > 2MB. BQ enforces a hard row 
size of 2MB.
 
 Review comment:
   it was 2MB now it's 100MB:
   https://cloud.google.com/bigquery/quotas
   Does this `TODO `even needs to be? Google can change the allowed size at 
will.
   Users may find that the service supports new size but Airflow prevents them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to