nuclearpinguin commented on a change in pull request #7570: [AIRFLOW-6946]
Switch to MySQL 5.7 in 2.0 as base
URL: https://github.com/apache/airflow/pull/7570#discussion_r392590665
##########
File path: airflow/models/base.py
##########
@@ -38,3 +38,11 @@
# used for typing
class Operator:
pass
+
+
+def get_id_collation_args():
+ collation = conf.get('core', 'sql_engine_collation_for_ids', fallback=None)
+ if collation:
+ return {'collation': collation}
+ else:
+ return {}
Review comment:
Also I'm wondering if response of this function will change over time...
Maybe it would be easier to use:
```python
COLLATION_ARGS = get_id_collation_args()
```
and import this value everywhere?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
