[
https://issues.apache.org/jira/browse/AIRFLOW-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059826#comment-17059826
]
ASF GitHub Bot commented on AIRFLOW-4175:
-----------------------------------------
OmairK commented on pull request #7733: [AIRFLOW-4175] S3Hook load_file should
support ACL policy paramete
URL: https://github.com/apache/airflow/pull/7733
- Added acl_policy parameter to all the S3Hook.load_*() and
S3Hook.copy_object() function
- Added unittest to test the response permissions when the
policy is passed
- Updated the docstring of the function
Co-authored-by: retornam <[email protected]>
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> S3Hook load_file should support ACL policy parameter
> ----------------------------------------------------
>
> Key: AIRFLOW-4175
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4175
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
> Affects Versions: 1.10.2
> Reporter: Keith O'Brien
> Priority: Major
> Labels: gsoc, gsoc2020, mentor
>
> We have a use case where we are uploading files to an S3 bucket in a
> different AWS account to the one Airflow is running in. AWS S3 supports this
> situation using the pre canned ACL policy, specifically
> {{bucket-owner-full-control. }}
> However, the current implementations of the {{S3Hook.load_*}}() and
> {{S3Hook.copy_object}}() methods do not allow us to supply any ACL policy for
> the file being uploaded/copied to S3.
> It would be good to add another optional parameter to the {{S3Hook}} methods
> called {{acl_policy}} which would then be passed into the boto3 client method
> calls like so
>
> {code}
> # load_file
> ...
> if encrypt:
> extra_args['ServerSideEncryption'] = "AES256"
> if acl_policy:
> extra_args['ACL'] = acl_policy
> client.upload_file(filename, bucket_name, key, ExtraArgs=extra_args){code}
>
> {code}
> # load_bytes
> ...
> if encrypt:
> extra_args['ServerSideEncryption'] = "AES256"
> if acl_policy:
> extra_args['ACL'] = acl_policy
> client.upload_file(filename, bucket_name, key, ExtraArgs=extra_args){code}
> {code}
> # copy_object
> self.get_conn().copy_object(Bucket=dest_bucket_name,
> Key=dest_bucket_key,
> CopySource=CopySource,
> ACL=acl_policy)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
