ashb commented on a change in pull request #7741: [AIRFLOW-7076] Add support
for HashiCorp Vault as Secrets Backend
URL: https://github.com/apache/airflow/pull/7741#discussion_r393601194
##########
File path: airflow/secrets/__init__.py
##########
@@ -50,7 +51,7 @@ def __init__(self, **kwargs):
pass
@abstractmethod
- def get_connections(self, conn_id) -> List[Connection]:
+ def get_connections(self, conn_id) -> Optional[List[Connection]]:
Review comment:
I don't think this should be changed -- return an empty list instead of none?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
