[ 
https://issues.apache.org/jira/browse/AIRFLOW-6836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061138#comment-17061138
 ] 

Sam Wheating edited comment on AIRFLOW-6836 at 3/17/20, 7:28 PM:
-----------------------------------------------------------------

[~kaxilnaik] - this was fixed in master due to changes to the baseExecutor 
which made self.running a set. However, these changes aren't reflected in 
1.10.9 where baseExecutor.running is a dict and debugExecutor expects 
self.running to be a set. 

I guess we can close this? Or can we patch this issue in the next 1.10 release?


was (Author: samwheating):
[~kaxilnaik] - this was fixed in master due to changes to the baseExecutor 
which made self.running a set. However, these changes aren't reflected in 
1.10.9 where baseExecutor.running is a dict and debugExecutor expects 
self.running to be a set. 



I guess we can close this? 

> DebugExecutor failing to change task state.
> -------------------------------------------
>
>                 Key: AIRFLOW-6836
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6836
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: executors
>    Affects Versions: 1.10.9
>            Reporter: Sam Wheating
>            Assignee: Sam Wheating
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 2.0.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Running a DAG locally with the DebugExecutor fails with the following error:
>  
> {noformat}
>   File 
> "/Users/samwheating/.pyenv/versions/3.7.3/lib/python3.7/site-packages/airflow/executors/debug_executor.py",
>  line 148, in change_state
>  self.running.remove(key)
>  AttributeError: 'dict' object has no attribute 'remove'
> {noformat}
> This seems to be because the change_state function is expecting a set rather 
> than a dict for `self.running`. This should be updated to use `del 
> self.running[key]` or `self.running.pop(key)`.
> I'll submit a PR for this tomorrow. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to