nuclearpinguin commented on a change in pull request #7748: [AIRFLOW-6752] Add
GoogleAnalyticsRetrieveAdsLinksListOperator
URL: https://github.com/apache/airflow/pull/7748#discussion_r394179317
##########
File path: airflow/providers/google/marketing_platform/hooks/analytics.py
##########
@@ -66,10 +66,43 @@ def list_accounts(self) -> List[Dict[str, Any]]:
# start index has value 1
request = accounts.list(start_index=len(result) + 1)
response = request.execute(num_retries=self.num_retries)
- result.extend(response.get('items', []))
+ result.extend(response.get("items", []))
# result is the number of fetched accounts from Analytics
# when all accounts will be add to the result
# the loop will be break
if response["totalResults"] <= len(result):
break
return result
+
+ def list_ad_words_links(
+ self, account_id: str, web_property_id: str
+ ) -> List[Dict[str, Any]]:
+ """
+ Lists webProperty-Google Ads links for a given web property.
+
+ # :param account_id: ID of the account which the given web property
belongs to.
+ # :type account_id: str
+ # :param web_property_id: Web property ID to retrieve the Google Ads
links for.
+ # :type web_property_id: str
Review comment:
Let's also fix this in `__init__`:
`gcp_connection_id: str = "google cloud default"` -> `gcp_connection_id: str
= "google_cloud_default"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
