ashb commented on a change in pull request #7753: [AIRFLOW-5705][depends on 
AIRFLOW-7076] Make AwsSsmSecretsBackend consistent with VaultBackend
URL: https://github.com/apache/airflow/pull/7753#discussion_r395314905
 
 

 ##########
 File path: airflow/providers/amazon/aws/secrets/ssm.py
 ##########
 @@ -37,34 +38,37 @@ class AwsSsmSecretsBackend(BaseSecretsBackend, 
LoggingMixin):
 
         [secrets]
         backend = airflow.providers.amazon.aws.secrets.ssm.AwsSsmSecretsBackend
-        backend_kwargs = {"prefix": "/airflow", "profile_name": null}
-
-    For example, if ssm path is ``/airflow/AIRFLOW_CONN_SMTP_DEFAULT``, this 
would be accessible if you
-    provide ``{"prefix": "/airflow"}`` and request conn_id ``smtp_default``.
+        backend_kwargs = {"connections_prefix": "/airflow/connections", 
"profile_name": null}
 
+    For example, if ssm path is ``/airflow/connections/smtp_default``, this 
would be accessible
+    if you provide ``{"connections_prefix": "/airflow"}`` and request conn_id 
``smtp_default``.
     """
 
-    def __init__(self, prefix: str = '/airflow', profile_name: Optional[str] = 
None, **kwargs):
-        self._prefix = prefix
+    def __init__(
+        self, connections_prefix: str = '/airflow/connections',
 
 Review comment:
   ```suggestion
           self,
           connections_prefix: str = '/airflow/connections',
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to