ashb commented on a change in pull request #7761: [AIRFLOW-7086] /dags/paused 
should be a PUT
URL: https://github.com/apache/airflow/pull/7761#discussion_r395348576
 
 

 ##########
 File path: airflow/www/api/experimental/endpoints.py
 ##########
 @@ -184,13 +184,11 @@ def task_info(dag_id, task_id):
     return jsonify(fields)
 
 
-# ToDo: Shouldn't this be a PUT method?
-@api_experimental.route('/dags/<string:dag_id>/paused/<string:paused>', 
methods=['GET'])
+@api_experimental.route('/dags/<string:dag_id>/pause/<string:pause_state>', 
methods=['PUT'])
 
 Review comment:
   POST is more typical here -- it's not wrong here, but I don't think we use 
PUT anywhere else in the current experimental API do we?
   
   Can you also add a note to UPDATING.md, and then we can pull this in to 
1.10.10

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to