ashb commented on a change in pull request #7245: [AIRFLOW-6624] Improve
webserver command with pidfile checking
URL: https://github.com/apache/airflow/pull/7245#discussion_r395553659
##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -195,15 +197,11 @@ def webserver(args):
port=args.port, host=args.hostname,
ssl_context=(ssl_cert, ssl_key) if ssl_cert and ssl_key else
None)
else:
- os.environ['SKIP_DAGS_PARSING'] = 'True'
- app = cached_app(None)
- pid, stdout, stderr, log_file = setup_locations(
+ pid_file, stdout, stderr, log_file = setup_locations(
"webserver", args.pid, args.stdout, args.stderr, args.log_file)
- os.environ.pop('SKIP_DAGS_PARSING')
Review comment:
App was unused, but this pre-warms the cache, and makes possible errors get
reported earlier (i.e. before demonization) so I am not sure about this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
