vpavlin commented on a change in pull request #14: fixed role and
non-existing-kind
URL:
https://github.com/apache/airflow-on-k8s-operator/pull/14#discussion_r395691195
##########
File path: controllers/airflowcluster_controller.go
##########
@@ -66,16 +66,16 @@ type AirflowClusterReconciler struct {
}
//
+kubebuilder:rbac:groups=apps,resources=statefulsets,verbs=get;list;watch;create;update;patch;delete
-//
+kubebuilder:rbac:groups=,resources=services,verbs=get;list;watch;create;update;patch;delete
-//
+kubebuilder:rbac:groups=,resources=configmaps,verbs=get;list;watch;create;update;patch;delete
+//
+kubebuilder:rbac:groups="",resources=services,verbs=get;list;watch;create;update;patch;delete
+//
+kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list;watch;create;update;patch;delete
//
+kubebuilder:rbac:groups=app.k8s.io,resources=applications,verbs=get;list;watch;create;update;patch;delete
//
+kubebuilder:rbac:groups=policy,resources=poddisruptionbudgets,verbs=get;list;watch;create;update;patch;delete
//
+kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=rolebindings,verbs=get;list;watch;create;update;patch;delete
-//
+kubebuilder:rbac:groups=,resources=secrets,verbs=get;list;watch;create;update;patch;delete
-//
+kubebuilder:rbac:groups=,resources=serviceaccounts,verbs=get;list;watch;create;update;patch;delete
+//
+kubebuilder:rbac:groups="",resources=secrets,verbs=get;list;watch;create;update;patch;delete
+//
+kubebuilder:rbac:groups="",resources=serviceaccounts,verbs=get;list;watch;create;update;patch;delete
//
+kubebuilder:rbac:groups=storage.k8s.io,resources=storageclasses,verbs=get;list;watch;create;update;patch;delete
-//
+kubebuilder:rbac:groups=airflow.apache.org,resources=airflowclusters,verbs=get;list;watch;create;update;patch;delete
+//
+kubebuilder:rbac:groups=airflow.apache.org,resources=airflowclusters;airflowclusters/finalizers,verbs=get;list;watch;create;update;patch;delete
Review comment:
It is standard for OpenShift, so that it is able to add ownerReferences to
the owned resources. It will do no harm when deployed on Kubernetes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
