potiuk commented on a change in pull request #7791: Add ability to specify a
maximum modified time for objects in GCSToGCSOperator
URL: https://github.com/apache/airflow/pull/7791#discussion_r395970036
##########
File path: airflow/providers/google/cloud/hooks/gcs.py
##########
@@ -307,6 +307,79 @@ def is_updated_after(self, bucket_name, object_name, ts):
return False
+ def is_updated_between(self, bucket_name, object_name, min_ts, max_ts):
+ """
+ Checks if an blob_name is updated in Google Cloud Storage.
+
+ :param bucket_name: The Google Cloud Storage bucket where the object
is.
+ :type bucket_name: str
+ :param object_name: The name of the object to check in the Google cloud
+ storage bucket.
+ :type object_name: str
+ :param min_ts: The minimum timestamp to check against.
Review comment:
I think we should be specific whether the min/max time is included or
excluded. My proposal will be to
include min_time but exclude max_time (min_time <= blob_update_time <
max_time).
This will mimic the behaviour of [0:x] operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
