xinbinhuang commented on a change in pull request #7795: [AIRFLOW-7104] Add 
Secret backend for GCP Secrets Manager
URL: https://github.com/apache/airflow/pull/7795#discussion_r396043869
 
 

 ##########
 File path: airflow/providers/google/cloud/utils/credentials_provider.py
 ##########
 @@ -158,3 +161,43 @@ def provide_gcp_conn_and_credentials(
         key_file_path, scopes, project_id
     ):
         yield
+
+
+def get_credentials_and_project_id(
 
 Review comment:
   I refactor the code to move the whole logic in `base.py` into 
`credentials_provider.py`. Let me know how you think

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to