turbaszek commented on a change in pull request #7795: [AIRFLOW-7104] Add
Secret backend for GCP Secrets Manager
URL: https://github.com/apache/airflow/pull/7795#discussion_r396067305
##########
File path: airflow/providers/google/cloud/utils/credentials_provider.py
##########
@@ -20,17 +20,23 @@
Google Cloud Platform authentication.
"""
import json
+import logging
import tempfile
from contextlib import contextmanager
-from typing import Dict, Optional, Sequence
+from typing import Dict, Optional, Sequence, Tuple
from urllib.parse import urlencode
+import google.auth
+import google.oauth2.service_account
from google.auth.environment_vars import CREDENTIALS
from airflow.exceptions import AirflowException
from airflow.utils.process_utils import patch_environ
+log = logging.getLogger(__name__)
+
AIRFLOW_CONN_GOOGLE_CLOUD_DEFAULT = "AIRFLOW_CONN_GOOGLE_CLOUD_DEFAULT"
+_DEFAULT_SCOPES = ('https://www.googleapis.com/auth/cloud-platform',) # type:
Sequence[str]
Review comment:
```suggestion
_DEFAULT_SCOPES: type: Sequence[str] =
('https://www.googleapis.com/auth/cloud-platform',)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
