michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075]
Operators for storing information from GCS into GA
URL: https://github.com/apache/airflow/pull/7743#discussion_r396949091
##########
File path: airflow/providers/google/marketing_platform/hooks/analytics.py
##########
@@ -30,15 +31,30 @@ class GoogleAnalyticsHook(CloudBaseHook):
def __init__(
self,
api_version: str = "v3",
- gcp_connection_id: str = "google_cloud_default",
+ gcp_conn_id: str = "google_cloud_default",
*args,
**kwargs
):
super().__init__(*args, **kwargs)
self.api_version = api_version
- self.gcp_connection_is = gcp_connection_id
+ self.gcp_connection_is = gcp_conn_id
self._conn = None
+ def _paginate(self, resource: Resource, list_args: Optional[Dict[str,
Any]] = None):
+ list_args = list_args or {}
+ result: List[Dict] = []
Review comment:
I like it. Much better then mine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
