mik-laj commented on a change in pull request #7853: Change signature of
GSheetsHook methods
URL: https://github.com/apache/airflow/pull/7853#discussion_r397298644
##########
File path: airflow/providers/google/suite/hooks/sheets.py
##########
@@ -48,13 +46,11 @@ class GSheetsHook(CloudBaseHook):
def __init__(
self,
- spreadsheet_id: str,
gcp_conn_id: str = 'google_cloud_default',
Review comment:
Has this Hook been released in any version of Airflow? If so, then we should
maintain backward compatibility. You can do it with a decorator. We have the
similar decorator in the codebase:
https://github.com/apache/airflow/blob/master/airflow/providers/google/cloud/hooks/dataflow.py#L52-L81
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
