kaxil commented on a change in pull request #7841: Requirements now depend on
python version
URL: https://github.com/apache/airflow/pull/7841#discussion_r397540533
##########
File path: scripts/ci/_utils.sh
##########
@@ -530,7 +531,7 @@ function confirm_image_rebuild() {
# Make sure to use /dev/tty first rather than stdin/stdout when
available - this way confirm
# will works also in case of pre-commits (git does not pass
stdin/stdout to pre-commit hooks)
# shellcheck disable=SC2094
- "${AIRFLOW_SOURCES}/confirm" "${ACTION} image ${THE_IMAGE_TYPE} (might
take some time)" \
+ "${AIRFLOW_SOURCES}/confirm" "${ACTION} image
${THE_IMAGE_TYPE}-${PYTHON_SHORT_VERSION}" \
Review comment:
```suggestion
"${AIRFLOW_SOURCES}/confirm" "${ACTION} image
${THE_IMAGE_TYPE}-python ${PYTHON_SHORT_VERSION}" \
```
?? not sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
