[
https://issues.apache.org/jira/browse/AIRFLOW-7108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066308#comment-17066308
]
ASF GitHub Bot commented on AIRFLOW-7108:
-----------------------------------------
xinbinhuang commented on pull request #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Fix CloudSecretsManagerBackend invalid connections_prefix
> ---------------------------------------------------------
>
> Key: AIRFLOW-7108
> URL: https://issues.apache.org/jira/browse/AIRFLOW-7108
> Project: Apache Airflow
> Issue Type: Task
> Components: security
> Affects Versions: 2.0.0, 1.10.10
> Reporter: Xinbin Huang
> Assignee: Xinbin Huang
> Priority: Major
>
> GCP Secrets Manager only accepts [a-zA-Z0-9-_]* as its valid secret id key.
> This PR fix the implementation and add checks in constructor
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
